linux-kernel December 2007 archive
Main Archive Page > Month Archives  > linux-kernel archives
linux-kernel: [AppArmor 20/47] Pass struct vfsmount to the inode

[AppArmor 20/47] Pass struct vfsmount to the inode_rename LSM hook

From: <John_at_nospam>
Date: Thu Dec 20 2007 - 14:09:30 GMT
To: akpm@linux-foundation.org


This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <tonyj@suse.de> Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: John Johansen <jjohansen@suse.de> --- fs/namei.c | 6 ++++-- include/linux/security.h | 13 ++++++++++--- security/dummy.c | 4 +++- security/security.c | 7 ++++---  security/selinux/hooks.c | 8 ++++++--  5 files changed, 27 insertions(+), 11 deletions(-)

  • a/fs/namei.c +++ b/fs/namei.c
    @@ -2616,7 +2616,8 @@ static int vfs_rename_dir(struct inode *
    return error; }
    • error = security_inode_rename(old_dir, old_dentry, new_dir, new_dentry); + error = security_inode_rename(old_dir, old_dentry, old_mnt, + new_dir, new_dentry, new_mnt); if (error) return error;

@@ -2650,7 +2651,8 @@ static int vfs_rename_other(struct inode
struct inode *target; int error; - error = security_inode_rename(old_dir, old_dentry, new_dir, new_dentry); + error = security_inode_rename(old_dir, old_dentry, old_mnt, + new_dir, new_dentry, new_mnt); if (error) return error;

  • a/include/linux/security.h +++ b/include/linux/security.h
    @@ -367,8 +367,10 @@ struct request_sock;
    • Check for permission to rename a file or directory.
    • @old_dir contains the inode structure for parent of the old link.
    • @old_dentry contains the dentry structure of the old link. + * @old_mnt is the vfsmount corresponding to @old_dentry (may be NULL).
    • @new_dir contains the inode structure for parent of the new link.
    • @new_dentry contains the dentry structure of the new link. + * @new_mnt is the vfsmount corresponding to @new_dentry (may be NULL).
    • Return 0 if permission is granted.
    • @inode_readlink:
    • Check the permission to read the symbolic link.
      @@ -1298,7 +1300,9 @@ struct security_operations {
      int (*inode_mknod) (struct inode *dir, struct dentry *dentry, struct vfsmount *mnt, int mode, dev_t dev); int (*inode_rename) (struct inode *old_dir, struct dentry *old_dentry, - struct inode *new_dir, struct dentry *new_dentry); + struct vfsmount *old_mnt, + struct inode *new_dir, struct dentry *new_dentry, + struct vfsmount *new_mnt); int (*inode_readlink) (struct dentry *dentry, struct vfsmount *mnt); int (*inode_follow_link) (struct dentry *dentry, struct nameidata *nd); int (*inode_permission) (struct inode *inode, int mask, struct nameidata *nd);
      @@ -1567,7 +1571,8 @@ int security_inode_rmdir(struct inode *d
      int security_inode_mknod(struct inode *dir, struct dentry *dentry, struct vfsmount *mnt, int mode, dev_t dev); int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry, - struct inode *new_dir, struct dentry *new_dentry); + struct vfsmount *old_mnt, struct inode *new_dir, + struct dentry *new_dentry, struct vfsmount *new_mnt); int security_inode_readlink(struct dentry *dentry, struct vfsmount *mnt); int security_inode_follow_link(struct dentry *dentry, struct nameidata *nd); int security_inode_permission(struct inode *inode, int mask, struct nameidata *nd);
      @@ -1924,8 +1929,10 @@ static inline int security_inode_mknod (

 static inline int security_inode_rename (struct inode *old_dir, struct dentry *old_dentry, + struct vfsmount *old_mnt, struct inode *new_dir, - struct dentry *new_dentry) + struct dentry *new_dentry, + struct vfsmount *new_mnt) { return 0;
 }
--- a/security/dummy.c
+++ b/security/dummy.c
@@ -335,8 +335,10 @@ static int dummy_inode_mknod (struct ino
 

 static int dummy_inode_rename (struct inode *old_inode, struct dentry *old_dentry, + struct vfsmount *old_mnt, struct inode *new_inode, - struct dentry *new_dentry) + struct dentry *new_dentry, + struct vfsmount *new_mnt) { return 0;
 }
--- a/security/security.c
+++ b/security/security.c
@@ -407,13 +407,14 @@ int security_inode_mknod(struct inode *d
 }  

 int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry, - struct inode *new_dir, struct dentry *new_dentry) + struct vfsmount *old_mnt, struct inode *new_dir, + struct dentry *new_dentry, struct vfsmount *new_mnt) { if (unlikely(IS_PRIVATE(old_dentry->d_inode) || (new_dentry->d_inode && IS_PRIVATE(new_dentry->d_inode)))) return 0; - return security_ops->inode_rename(old_dir, old_dentry, - new_dir, new_dentry); + return security_ops->inode_rename(old_dir, old_dentry, old_mnt, + new_dir, new_dentry, new_mnt);
 }  

 int security_inode_readlink(struct dentry *dentry, struct vfsmount *mnt) --- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2473,8 +2473,12 @@ static int selinux_inode_mknod(struct in

         return may_create(dir, dentry, inode_mode_to_security_class(mode));  }   -static int selinux_inode_rename(struct inode *old_inode, struct dentry *old_dentry, - struct inode *new_inode, struct dentry *new_dentry) +static int selinux_inode_rename(struct inode *old_inode, + struct dentry *old_dentry, + struct vfsmount *old_mnt, + struct inode *new_inode, + struct dentry *new_dentry, + struct vfsmount *new_mnt) { return may_rename(old_inode, old_dentry, new_inode, new_dentry);  } -- - To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html