[PATCH 1/3] flex_array: fix the panic issue when calling flex_array_alloc() without __GFP_ZERO

From: Changli Gao <xiaosuo_at_nospam>
Date: Fri Apr 09 2010 - 04:05:46 GMT
To: Patrick McHardy <kaber@trash.net>

fix the panic issue when calling flex_array_alloc() without __GFP_ZERO.

memset is called with the wrong address, then kernel panics.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---- lib/flex_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/flex_array.c b/lib/flex_array.c index 66eef2e..6fbb514 100644 --- a/lib/flex_array.c +++ b/lib/flex_array.c @@ -99,7 +99,7 @@ struct flex_array *flex_array_alloc(int element_size, unsigned int total, ret->element_size = element_size; ret->total_nr_elements = total; if (elements_fit_in_base(ret) && !(flags & __GFP_ZERO)) - memset(ret->parts[0], FLEX_ARRAY_FREE, + memset(&ret->parts[0], FLEX_ARRAY_FREE, FLEX_ARRAY_BASE_BYTES_LEFT); return ret; } -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

This message: [ Message body ]
Next message: Changli Gao: "[PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding."
Previous message: Valdis.Kletnieks_at_nospam: "Re: mmotm 2010-04-05-16-09 uploaded"
Next in thread: David Rientjes: "Re: [PATCH 1/3] flex_array: fix the panic issue when calling flex_array_alloc() without __GFP_ZERO"
Reply: David Rientjes: "Re: [PATCH 1/3] flex_array: fix the panic issue when calling flex_array_alloc() without __GFP_ZERO"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ]