netfilter-devel April 2010 archive
Main Archive Page > Month Archives  > netfilter-devel archives
netfilter-devel: Re: [PATCH 3/3] nfnetlink_queue: use hash table

Re: [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding.

From: Changli Gao <xiaosuo_at_nospam>
Date: Thu Apr 15 2010 - 15:01:41 GMT
To: Patrick McHardy <kaber@trash.net>

On Thu, Apr 15, 2010 at 10:46 PM, Patrick McHardy <kaber@trash.net> wrote:
> Patrick McHardy wrote:
>>
>> That should be easily fixable. For the lookup we can add a reference
>> counter so we don't need the rcu read side critical section.
>
> Actually we don't even need that, since we're holding nfnl_mutex the
> instance can't go away.
>

I don't think so. a netlink queue instance maybe destroyed by
nfqnl_rcv_nl_event(). And the function is called by netlink directly
without nfnl_mutex.

-- Regards´╝î Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html