openssh-unix-dev August 2010 archive
Main Archive Page > Month Archives  > openssh-unix-dev archives
openssh-unix-dev: Re: Call for testing: OpenSSH-5.6

Re: Call for testing: OpenSSH-5.6

From: Alan Barrett <apb_at_nospam>
Date: Wed Aug 11 2010 - 22:22:30 GMT
To: Damien Miller <djm@mindrot.org>

On Tue, 10 Aug 2010, Damien Miller wrote:
> OpenSSH 5.6 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a moderately large
> release, with a number of new features and bug fixes.

I attach two patches relative to the 20100810 snapshot.

1) ctype(3) functions should not be called with char arguments;
   they should be called with unsigned char arguments.
2) in sftp-common.c, strmode() requires #include <unistd.h>,
   and the results of user_from_uid() and group_from_gid()
   are pointers to const char, not pointers to plain char

I also attach the semantic patch that generated patch 1. Use
"spatch -inplace -sp_file ctype.spatch -dir .".

The result compiles successfully with "-Werror" appended to CFLAGS,
and passes all tests on NetBSD-5.99.27/i386.

--apb (Alan Barrett)

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev