Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information

• Eric Paris <eparis@redhat.com> wrote:

> Adds security_get_sb_mnt_opts, security_set_sb_mnt_opts, and
> security_clont_sb_mnt_opts to the LSM and to SELinux. This is in
> preparation for NFS to be able to own its own mount options and remove
> the NFS specific code from SELinux.

What is the purpose of security_clone_sb_mnt_opts? I see where it is being used, but it's not clear to me why it is necessary. The old SELinux code doesn't clone the options, it filters out the ones it cares about. If that is the behavior you'd expect of this hook, I suggest the name reflect that, perhaps security_filter_sb_mnt_opts.

Casey Schaufler
casey@schaufler-ca.com -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.

• This message: [ Message body ]
• Next message: Eric Paris: "Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information"
• Previous message: Christopher J. PeBenito: "Re: [PATCH] refpolicy: system_hostname changes"
• In reply to: Eric Paris: "[PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information"
• Next in thread: Eric Paris: "Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information"
• Reply: Eric Paris: "Re: [PATCH] 1/2 SELinux: Add get, set, and cloning of superblock security information"

• Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ]