selinux December 2010 archive
Main Archive Page > Month Archives  > selinux archives
selinux: Re: [PATCH] selinux: cache sidtab_context_to_sid result

Re: [PATCH] selinux: cache sidtab_context_to_sid results

From: James Morris <jmorris_at_nospam>
Date: Wed Dec 08 2010 - 21:27:10 GMT
To: Eric Paris <eparis@redhat.com>

On Tue, 7 Dec 2010, Eric Paris wrote:

> > This sounds a bit like a magazine cache -- should be useful. Have you
> > thought about making it per-cpu ?
>
> I hadn't. I figure that as long as we've had a single hash table lookup
> (the wrong direction for the hash table) for all CPUs holding a spinlock
> that this is such a clear win there wasn't a need for any complexity or
> space tradeoff.
>
> If you think differently (and have a way we could benchmark the changes)
> it wouldn't be hard to do, just don't know if it's worth it....

Nope, just wondering what you thought. It's a clear win on its own.

-- James Morris <jmorris@namei.org> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.