| Main Archive Page > Month Archives > spamassassin-dev archives |
[Bug 6416] [review] Avoid warnings in AutoWhitelist when Received header is bad or misparsed
From: <bugzilla-daemon_at_nospam>Date: Wed Apr 21 2010 - 16:08:07 GMT
To: dev@spamassassin.apache.org
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6416
--- Comment #3 from Mark Martinec <Mark.Martinec@ijs.si> 2010-04-21 12:08:05 EDT ---
> I don't understand the reasoning here. why does this move the else clause?
The issue here is that either:
- $origip is undefined in the first place
- or the ip_to_awl_key() returns undef
So in this second case, $origip would not end up as 'none', but would
remain undef, leading to the warning.
There is no 'else' in the fixed code, just two independent 'if's.
The $origip becomes 'none' either when it was initially undef,
or when ip_to_awl_key() returns undef.
-- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.