spamassassin-users October 2010 archive
Main Archive Page > Month Archives  > spamassassin-users archives
spamassassin-users: Re: SA 3.3.1 and NetAddr::IP 4.034

Re: SA 3.3.1 and NetAddr::IP 4.034

From: Mark Martinec <Mark.Martinec+sa_at_nospam>
Date: Fri Oct 29 2010 - 16:11:25 GMT
To: users@spamassassin.apache.org

Giampaolo,

> > still incorrect:
> > $ perl -le 'use NetAddr::IP; print NetAddr::IP->new6("127/8")'
> > 0:0:0:0:0:0:7F00:0/8
>
> This seems way too ambiguos to me, isn't?

No, it isn't ambiguous, it is a perfectly valid syntax for an IPv4
network, although nowadays somewhat deprecated in favour for the
more obvious full quad notation.

> How could the NetAddr::IP module get you're instantiating an IPv6 net
> address, after all. That seems to me a valid IPv6 syntax, too...

No, it isn't a valid IPv6 address. The IPv6 addressing syntax
does not allow shortening in the same way as was allowed for IPv4.
An IPv6 address must specify full 128 bits, but allows for
compaction using a :: notation, e.g. 2001:db8::/32

> > A workaround for SpamAssassin is to avoid shorthand IPv4 network
> > specifications, both in a config file (trusted/internal networks,
> > if any), as well as the hardwired one:
> >
> > - $set->add_cidr ('127/8');
> > + $set->add_cidr ('127.0.0.0/8');
>
> Wow, such a beast was in Conf.pm, uhu?

Well, yes. Not nice, but not wrong either.

> So, SA 3.3.2 will be NetAddr::IP 4.035 -compatible, right?

There would still be an issue if a site config file uses a
shorthand IPv4 network syntax, so the NetAddr::IP would better
be fixed anyway.

Michael,

> > A workaround for SpamAssassin is to avoid shorthand IPv4 network
> > specifications, both in a config file (trusted/internal networks,
> > if any), as well as the hardwired one:

> Patch for SpamAssassin Ports, rpm's and yum? or would it hurt to do this
> to 3.3.2 before it gets released?

Sure, go ahead, can't hurt. The patch is now in the SA trunk.
Is it worth opening a ticket and putting it into the 3.3 branch too?

  Mark