| Main Archive Page > Month Archives > wireshark-dev archives |
Re: [Wireshark-dev] Clear packet comment should remove the comment entirely?
From: Jeff Morriss <jeff.morriss.ws_at_nospam>Date: Mon Apr 02 2012 - 16:30:58 GMT
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Anders Broman wrote:
>
>
> -----Original Message-----
> From: wireshark-dev-bounces@wireshark.org [mailto:wireshark-dev-bounces@wireshark.org] On Behalf Of Jeff Morriss
> Sent: den 2 april 2012 16:53
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] Clear packet comment should remove the comment entirely?
>
> Anders Broman wrote:
>>> Stephen Fisher skrev 2012-03-30 17:59:
>>>> Unfortunately, I haven't been following development much lately. I
>>>> see that we have a packet comment feature now. Is there a way to
>>>> remove a comment entirely? I envision the clear button in the "Edit
>>>> or Add Packet Comments" could do this instead of just clearing the
>>>> text buffer, but I see that functionality would probably have to go
>>>> down into the new packet list code and further into the frame data's
>>>> opt_comment variable.
>>> If you press the clear button and then save the file and reload the
>>> saved file I think the comment should be gone.
>> I'd been thinking about this some too; one of the first few things I wanted to do in playing with it was to Delete the comment (from the file, from the packet). >I imagine users will want to too; I think leaving an empty comment feels like a workaround (even if it really deletes the comment from the file).
>>
>> I just didn't (and probably won't soon) have time to do anything about it.
>
> Fixed in revision 41895.
What I was (as a user) looking for was a "Delete comment" option
somewhere in the UI. Clearing the comment causing the comment to be
deleted works, but will users expect it? (Or should they learn to
expect it?)
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe